Skip to content

Remove old code and organize deps#480

Merged
sbs2001 merged 8 commits intoaboutcode-org:mainfrom
sbs2001:housekeeping
Jun 20, 2021
Merged

Remove old code and organize deps#480
sbs2001 merged 8 commits intoaboutcode-org:mainfrom
sbs2001:housekeeping

Conversation

@sbs2001
Copy link
Collaborator

@sbs2001 sbs2001 commented Jun 13, 2021

No description provided.

sbs2001 added 3 commits June 13, 2021 12:09
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@sbs2001
Copy link
Collaborator Author

sbs2001 commented Jun 13, 2021

@rolfschr we are trying to seprate the dev deps and project deps into separate files. Could you modify the nix tests to install both of these ?

rolfschr and others added 5 commits June 16, 2021 14:12
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Make Nix tests install Python dev deps
@sbs2001 sbs2001 requested a review from pombredanne June 20, 2021 05:26
@sbs2001 sbs2001 merged commit 753dd72 into aboutcode-org:main Jun 20, 2021
@Hritik14
Copy link
Collaborator

Hey @sbs2001
This commit removes most of the occurrences of DJANGO_DEV, yet does not remove all of them:

venv ❯ git grep -n "DJANGO_DEV"
.github/workflows/main.yml:56:          DJANGO_DEV: 1
.github/workflows/upstream_test.yml:52:          DJANGO_DEV: 1
Dockerfile:10:    DJANGO_DEV=1 python manage.py collectstatic
README.rst:269:    Environment="DJANGO_DEV=1"
docker-compose.yml:6:        - DJANGO_DEV=1
etc/nix/flake.nix:131:              export DJANGO_DEV=1
etc/nix/test-import-using-nix.sh:13:export DJANGO_DEV=${DJANGO_DEV:-1}

Further, as this commit totally removes enabling debug mode from the environment variables, I think we should ship with a development version of vulnerablecode/settings.py with DEBUG enabled as well.

@pombredanne
Copy link
Member

@Hritik14 Developers that know about debugging can enable it themselves. I do not see a point to make this easier. Instead a commented out setting is usually enough with a note.
Leaving some door open otherwise may not be a satisfying option and the benefits are low IMHO

@sbs2001
Copy link
Collaborator Author

sbs2001 commented Jun 21, 2021

@Hritik14 yeah, seems like I missed some of em ;).

@pombredanne I don't think we need anything else other than django's built in DEBUG=True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants