Make URL mandatory for reference model#910
Closed
TG1999 wants to merge 2 commits intoaboutcode-org:mainfrom
Closed
Make URL mandatory for reference model#910TG1999 wants to merge 2 commits intoaboutcode-org:mainfrom
TG1999 wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
Raise error when URL is not provided for a reference Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
reviewed
Sep 9, 2022
| ) | ||
| ordering = ["reference_id", "url"] | ||
|
|
||
| def save(self, *args, **kwargs): |
Member
There was a problem hiding this comment.
I am not sure this is the correct way to make a field mandatory.
Rather
- you need a data migration first to fix things
- the model needs to be changed: https://github.com/nexB/vulnerablecode/pull/910/files#diff-7f9f2c92e7163b06d21fa139369d75caed6561d0368b60ea2516cece0220eb5bR108 this should be explicit blank=False, null=False
?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise error when URL is not provided for a reference
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com