Several bugs on nogo points in Android (file interface)

[Totorrr]

Hello,

I did several tests using a nogo point on a way that was often ignored or behaving unexpectedly. I tested brouter v1.7.8, v1.7.7 and v1.7.6 and got the same issues on the 3 versions.

TL;DR

• the nogo point is always ignored in routing via the service interface if defined in import/favourites.gpx (but it is displayed in the brouter app nogo points list),
• the nogo point is considered in routing via the service interface if defined in import/tracks/nogo.gpx (but only if unchecked in the brouter app nogo points list when doing service configuration),
• if routing within the brouter app, the nogo point is considered in both cases above, but only if unchecked in the brouter app nogo points,

Buggy cases

Just one favourites.gpx file

• add a favourites.gpx file in the import directory
• this file contains 3 points : 1 for origin, 1 for destination, 1 named nogo

When using the brouter app to compute a from/to route, a screen allows to (un)check the nogo point.

Problem

The nogo point in the brouter app is considered only when I uncheck nogo. When nogo is checked, the nogo point is ignored.

If I use the service interface (with OsmAnd), the nogo point is always ignored. I can map bicycle_short to the profile and also check or uncheck the nogo point, but whatever I choose, this nogo point is always ignored when computing the route.

One favourites.gpx file and one nogo.gpx file

• add a favourites.gpx file in the import directory
• this file contains 2 points : 1 for origin, 1 for destination
• add a nogo.gpx file in the import/tracks directory
• this file contains 1 point named nogo

This works better (but still buggy).

Problem

When computing the route within brouter, the nogo point is taken into account correctly, but only if I uncheck nogo on the screen that shows me the nogo points available.

With the service interface, same behaviour. The nogo point is taken into account only if I uncheck the nogo point when configuring the server mode mapping.

Expected behaviours

• I expect the nogo point to be considered if I check it, not if I unchecked it.
• I expect the nogo point to be considered in the service interface when defined either in favourites.gpx or nogo.gpx, not just the latter.

Related issue?

Issue #512 might be related to this one.

[vodie]

If you have to select the nogo, you have to select it every time you add a nogo in the gpx. So this is done to make it easier and set veto for the nogos to ignore them. New nogos are on by default.

[Totorrr]

If you have to select the nogo, you have to select it every time you add a nogo in the gpx. So this is done to make it easier and set veto for the nogos to ignore them. New nogos are on by default.

I am not sure I fully understand the point you are trying to make @vodie, but I will try to answer.

In my case, when the list of nogo appears, it contains only one nogo, and by default, it is checked. Following what I wrote earlier, when it is checked (the default), it is ignored. So, by default, my nogo is ignored. Except maybe if I don't (re)configure the service interface at all after adding a nogo.gpx file containing nogo points, and leave it as is, the nogo point may be taken into consideration as it was not selected (checked) within the brouter app.