-
Notifications
You must be signed in to change notification settings - Fork 142
Update lookups #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update lookups #458
Conversation
|
If we generate new segments using this update
|
Yes. When the server update is done and an apk user updates the data lookups.dat and profiles are downloaded first then rd5 download starts. But when user has called e.g. only one rd5 but has 4 on board he has a problem when next enter an outdated rd5 - he will get a notice.
When index changes a new number is needed. Smaller changes like aliases don't change it.
Yes, until new apk version is out. Current looks for hiking-beta |
|
I think breaking things for (many) users is bad and like I wrote in #416, I see quite some pain for removing oneway=true. I did post PR to update the profiles of @poutnik, see poutnikl/Trekking-Poutnik/pull/30 but that has not been merged as of now. Apart from the profiles of @poutnik it also impacts most other profiles so I think it is better to keep it in the profile for now, but let's remove it for the brouter profiles.
How does that notice look like? Also, what about return meta.lookupVersion == 10; For the remainder the patch looks good to me, I can run later this weekend a map generation run with it and give some stats. |
|
Quoting @polyscias from #416 (comment):
I wondered where the The OSM tag history graph (see also Taginfo chronology) looks suspicious: And indeed, there are two unique uses:
The latter and other sporadic edits are all using the iD editor, which actually has that value in the list of suggestions when using the properties table, which is most probably because of the value count of that single import. Therefore I think the [1] curl -o changeset-21660337.osc https://www.openstreetmap.org/api/0.6/changeset/21660337/download
grep "grade3-5" changeset-21660337.osc | wc -l |
|
Nice analysis @nrenner! I am perfectly fine with removing the grade3-5 alias but my opinion is, also with knowing this story, such an alias is fine. There are more tags in lookups.dat that are undocumented, for instance noexit=yes in way context and junction=approach |
I have somehow missed the PR and related discussion. I will try to address it and generate new profiles, but after Aug 15, due vacation. Another delay will be for LocusMap users, with profiles embedded to application or online LocusMap client. They use profiles from several sources. |
That would be nice.
Do you have some more information on this, in particular the exact profiles that are used? I like to add them to my collection of profile that I check for impact of this update.
With quite some delay I did run it and looking at all the .rd5 files generated versus those on http://brouter.de/brouter/segments4/ The extremes: I am planning to get the updated lookup.dat, profiles and one .rd5 on my mobile and see what it does. |
|
See also brouter-web#669, can we add also:
The first two are accessible on foot and a pier is often a way to access a ferry both on foot and by bicycle. |
|
I'm wondering if we can add 'stream' in the profile. Currently, we can route via waterway=river but not streams. See also https://wiki.openstreetmap.org/wiki/Tag:waterway=stream |
|
Added T1-hiking again to the lookups.dat. It is not used anymore but the hiking-mountain profile contains it. So I followed @polyscias
And a check of the recently added tags/values was also performed. |
|
Please do not forget this test for your profiles |
|
The values |
|
@afischerdev I don't like the alias for the |
|
@ProBackup-nl Looks a little bit like the traffic_calming icons. You are very interested and committed to this topic. My be you like to do more investigation how to reduce this types and classify the types by penalty. |
|
@afischerdev In case some of the |
What we need to know, depends on the type of transportation: by foot, horse, boat, train or MTB the traffic calming relevance is absent, on a slow bicycle a little near absent. More relevant is traffic calming when using a velomobile or moped, and those are different compared to a car or wide truck. The iD editor has 12 tags translated into Dutch, of which 8 tags contain an icon. Amazing is that from the brouter profiles2 only gravel and quaelnix-gravel use traffic_calming=* (one penalty for any value). The frequency of travel_calming in NL and riding a velomobile without suspension lead me to improving the vm-touristic profile. For me personally the traffic_calming order of importance:
|
|
@xuiqzy @ProBackup-nl traffic_calming;0000000000 main_value list of alias |
|
For
no|island|rumble_strip|painted_table For
For bicycle profiles it's handy to know if there is a |
|
@afischerdev I updated the comment above, with traffic_calming number 9 |
|
Hi, noob question here: I want to have the via_ferrata tags information. I can't just go ahead and use the new lookups with the current rd5 files right? From the developer guide:
|
|
Hello everyone, Kind regards, Ruben |

This is the call for a bigger update on lookups.dat
The Android apk doesn't need an update for that. Lookups.dat and profiles are updated automaticly.
Next apk update will then contain the new versions.
So only web services are affected.
And an update for the profiles is needed when there is an interest on man_made=pier or other changes.
Please see #416 for more.