Conversation
.md -> .rst Fixes: 00fb1a4 ("Convert markdown to reStructuredText") Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the library version from 1.99.0 to 2.0.0, indicating a major release with breaking changes. The update includes version number changes across multiple build configuration files and documentation format updates.
- Version numbers updated across header file, Makefile, and RPM spec file
- Documentation file extensions changed from .md to .rst format
- Changelog entry added noting API breaking changes in ac_circ_buf
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/include/libac.h | Updates major version from 1 to 2 and minor version from 99 to 0 |
| src/Makefile | Updates SOVER and VERSION variables to reflect 2.0.0 release |
| libac.spec | Updates RPM spec version, symbolic link target, documentation files, and adds changelog entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Lots of fixes all over. | ||
|
|
||
| * Thu Apr 11 2019 Andrew Clayton <andrew@digital-domain.net> - 1.0.1-1 | ||
| - Fix the libray so version in the Makefile and rpm spec |
There was a problem hiding this comment.
Corrected spelling of 'libray' to 'library'.
Suggested change
| - Fix the libray so version in the Makefile and rpm spec | |
| - Fix the library so version in the Makefile and rpm spec |
Clang 21 added support for the -Wunterminated-string-initialization warning as added in GCC 15. Commit 4e5bb56 ("Add a __nonstring macro") added a macro around the "nonstring" attribute when using GCC to quell this warning when desired. Now that clang also has this warning we now get tripped up as we did in GCC. Change the guard around the macro to use __has_attribute() instead of checking for the compiler as simply enabling also for clang will trigger warnings from older clangs that don't have the "nonstring" attribute. __has_attribute() is supported from GCC 5 and Clang 2.9, which should be fine for us. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.