fix: add Node.js setup step to CI test job (frontend build fails on Node 18)

[acailic]

Summary

• Add actions/setup-node@v6 with Node 22 + npm cache to the test CI job, before the frontend build and test steps — makes Node version deterministic and matches the dep-check job
• Add frontend/.nvmrc pinned to 22 so local developers using nvm/volta get the right version automatically
• Add engines field to frontend/package.json (>=20.19 || >=22.12) to document and enforce the Vite 8 requirement

Fixes #149

Test plan

• CI test job now sets up Node 22 before npm ci && npm run build — no more runner-default version dependency
• frontend/.nvmrc present — nvm use / volta picks up Node 22 automatically
• frontend/package.json engines field warns when wrong Node is used locally
• ruff check . passes locally (no Python changes)
• Existing pytest suite unaffected

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 434438b92c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Encode disjoint Node engine ranges correctly

"node": ">=20.19 || >=22.12" is logically equivalent to just >=20.19, so it does not enforce the intended split support window and will treat Node 21.x (and any 22.x) as valid. That weakens the guardrail this commit adds: developers can run with versions that frontend deps in this repo already declare as unsupported (^20.19.0 || ^22.12.0 || >=24.0.0 in frontend/package-lock.json) and only hit failures later during install/build. Use a non-overlapping range such as ^20.19.0 || >=22.12.0 to make the engine check actually catch unsupported runtimes.

Useful? React with 👍 / 👎.

[acailic]

Fixed. engines.node in frontend/package.json is now ^20.19.0 || >=22.12.0, which properly excludes Node 21.x and 22.0–22.11 and mirrors Vite 8's actual requirement.

[Copilot]

Pull request overview

This PR makes the frontend Node.js version requirement explicit and ensures CI uses a compatible Node version so Vite 8 builds don’t fail on older runner defaults.

Changes:

• Add actions/setup-node@v6 (Node 22 + npm cache) to the CI test job before frontend build/tests.
• Add frontend/.nvmrc to guide local Node version selection.
• Add a Node engines constraint to frontend/package.json to document/enforce the required Node range.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
frontend/package.json	Adds engines.node constraint for Node compatibility with Vite 8.
frontend/.nvmrc	Pins local Node major version for nvm/volta workflows.
.github/workflows/ci.yml	Ensures CI test job installs a compatible Node version and enables npm caching before building/testing the frontend.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The engines.node range >=20.19 || >=22.12 collapses to just >=20.19, so it will still allow Node 22.0–22.11 even though Vite’s deps require ^20.19.0 || >=22.12.0 (see frontend/package-lock.json for @vitejs/plugin-react). Update this range so it actually excludes unsupported Node 22.x versions below 22.12 and uses full semver (e.g., patch-level) to match the dependency requirement.

Suggested change

	"node": ">=20.19 || >=22.12"
	"node": "^20.19.0 || >=22.12.0"

[acailic]

Applied the suggestion — engines.node is now ^20.19.0 || >=22.12.0 in frontend/package.json.

[Copilot]

.nvmrc set to 22 can pick an already-installed Node 22.x that is <22.12 (nvm selects a matching installed version), which will still fail the Vite 8 engine requirement. Consider pinning at least 22.12.0 (or another known-good version) to prevent local builds from using an incompatible 22.x.

Suggested change

	22
	22.12.0

[acailic]

Fixed. frontend/.nvmrc is now pinned to 22.12.0 so nvm use / fnm use won't select an incompatible early 22.x.

[Copilot]

To keep CI consistent with the new frontend/.nvmrc and the Vite 8 requirement (Node 22.12+), consider using node-version-file: frontend/.nvmrc (or pinning node-version to a minimum like 22.12.0) instead of the broad major "22". This avoids version drift and prevents CI from ever selecting an incompatible early 22.x release.

Suggested change

	node-version: "22"
	node-version-file: frontend/.nvmrc

[acailic]

Applied the suggestion — both setup-node steps in ci.yml (test and dep-check jobs) now use node-version-file: frontend/.nvmrc so CI reads the version from a single source of truth (22.12.0).