Add a raw bytes cache mode #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Seems interesting. I'll try to take a look in the next few days. It doesn't look like it changes the API at all, correct? |
Author
|
Yes, I avoided API and behavorial changes. I will look into the failing CacheSizeTest. AFAICT the changes should not break it, at least not by design. |
Author
|
OK, I broke the test. It seems to be about the cache size tracking; maybe you'll spot my mistake right away but I will not have time to fix it before next monday. |
Owner
|
Ya, I noticed that too. I'll try poking around but with Thanksgiving coming up soon, I might be a bit lazy getting to it. |
This intends to support zerocopy/SendFile scenarios. There is no serialization in this mode, the cache is basically managing a bunch of files. The mode intentionally only accepts byte[] or streams, it does not support fetching them to avoid memory and stream lifetime issues. Because of the lifetime issue, a configurable safety margin is added to the expiry logic.
Author
|
The fix was to discount for the possibility that a file write replaces an existing file (and thus payload size). I hope appveyor agrees. |
Owner
|
Looks good! |
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have written a small extension to use FileCache as a raw byte store. I can thus store
byte[]s orStreams and FileCache will return accessible path names. This is to support SendFile or scatter/gather IO.So far the results look good in my use case. I added a bit of documentation and file enumeration instead of array creation.