Fixing bug introduced in PR #127 #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue_block2core function.
JRPan
requested review from
a team and
William-An
and removed request for
a team
Author
|
Can we make this higher priority? This is breaking dev. btw the reviewer was assigned by algorithm :) so don't blame me. |
Author
|
This needs to be merged first |
LAhmos
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127 is causing SEGF on PTX RTX 3070 simulations.
Two problems here
at
set_kernel_done, the kernel is cleared. But get_stream_id is getting is checking m_kernel of the shader core to get stream id. Since m_kernel is cleared, this caused SEGF.