[mlir][dxsa] Add dcl_input and dcl_output instructions#132
Merged
tagolog merged 2 commits intoMay 21, 2026
Merged
Conversation
asavonic
reviewed
May 20, 2026
| let assemblyFormat = "$value"; | ||
| } | ||
|
|
||
| def DXSA_InlineOperandType_Temp : I32EnumAttrCase<"temp", 0>; |
Contributor
There was a problem hiding this comment.
I think it would be great if we can use these enums for regular operands as well.
Author
There was a problem hiding this comment.
Yes, I plan to refine regular operation right after all DCL operations and reuse this operand for regular operations also.
Contributor
There was a problem hiding this comment.
Sounds good. When we use them for regular operations, perhaps we'll need to remove Inline prefix, but it is a minor thing that we can address later.
Example: dxsa.dcl_input %v0 dxsa.dcl_output %o0 Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
Encode the operand as an inline attribute instead of separate SSA values. Example: dxsa.dcl_input <type = input, components = 4, mask = <x>, index = [0]> dxsa.dcl_output <type = output, components = 4, mask = <x, y, z, w>, index = [0]> Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
tagolog
force-pushed
the
dxsa-mlir-dcl_input-and-dcl_output
branch
from
35f7d26 to
bae2b2c
Compare
asavonic
approved these changes
May 21, 2026
| let assemblyFormat = "$value"; | ||
| } | ||
|
|
||
| def DXSA_InlineOperandType_Temp : I32EnumAttrCase<"temp", 0>; |
Contributor
There was a problem hiding this comment.
Sounds good. When we use them for regular operations, perhaps we'll need to remove Inline prefix, but it is a minor thing that we can address later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_input <type = input, components = 4, mask = , index = [0]>
dxsa.dcl_output <type = output, components = 4, mask = <x, y, z, w>, index = [0]>