Dxsa mlir dcl constant buffer and other ops#133
Open
tagolog wants to merge 1 commit into
Open
Conversation
asavonic
reviewed
May 21, 2026
| return builder.buildDclOutput(*operand, loc); | ||
| } | ||
|
|
||
| FailureOr<Instruction> parseDclConstantBuffer(uint32_t opcodeToken, |
Contributor
There was a problem hiding this comment.
For Shader Model 5.1 and later, constant buffer opcode is followed by 3 operands: range, size and index.
Looks like we only handle Shader Model 4.0 through 5.0.
| if (!accessPattern) | ||
| return emitError(loc, "unknown constant buffer access pattern: ") | ||
| << rawAccessPattern; | ||
| auto operand = parseInlineOperand(); |
Contributor
There was a problem hiding this comment.
The operand for dcl_constantBuffer is fake - it can only be D3D10_SB_OPERAND_TYPE_CONSTANT_BUFFER, and we only need indices from it. The second index is also fake: it defines size of a buffer. Other properties of operands are meaningless - components, mask, swizzle. I don't think they are used for this instruction.
asavonic
reviewed
May 21, 2026
| LogicalResult | ||
| InlineOperandAttr::verify(function_ref<InFlightDiagnostic()> emitError, | ||
| ::mlir::dxsa::InlineOperandType /*type*/, | ||
| uint32_t components, |
Contributor
There was a problem hiding this comment.
Do we verify that components can only be 0, 1, or 4?
| ctx, static_cast<dxsa::ComponentName>(comp.swizzle[0]), | ||
| static_cast<dxsa::ComponentName>(comp.swizzle[1]), | ||
| static_cast<dxsa::ComponentName>(comp.swizzle[2]), | ||
| static_cast<dxsa::ComponentName>(comp.swizzle[3])); |
Contributor
There was a problem hiding this comment.
Can we use symbolize to verify range?
asavonic
reviewed
May 21, 2026
| def DXSA_SystemValueNameAttr : | ||
| EnumAttr<DXSADialect, DXSA_SystemValueName, "system_value_name"> { | ||
| let assemblyFormat = "$value"; | ||
| let assemblyFormat = "`<` $value `>`"; |
Contributor
There was a problem hiding this comment.
Why do we need angle brackets here?
| }]; | ||
| let parameters = (ins | ||
| EnumParameter<DXSA_InlineOperandType>:$type, | ||
| "uint32_t":$components, |
Contributor
There was a problem hiding this comment.
Why uint32_t and not, say, I32Attr?
…t, dcl_hs_join_phase_instance_count, dcl_hs_max_tessfactor, dcl_index_range, dcl_output_sgv, dcl_output_siv and dcl_tgsm_raw instructions Example: dxsa.dcl_constant_buffer <type = constant_buffer, components = 4, swizzle = <x, y, z, w>, index = [0, 1]>, <immediateIndexed> dxsa.dcl_hs_fork_phase_instance_count 4 dxsa.dcl_hs_join_phase_instance_count 2 dxsa.dcl_hs_max_tessfactor 6.400000e+01 dxsa.dcl_index_range <type = input, components = 4, mask = <x, y, z, w>, index = [4]>, 6 dxsa.dcl_output_sgv <type = output, components = 4, mask = <x>, index = [0]>, <primitiveID> dxsa.dcl_output_siv <type = output, components = 4, mask = <x, y, z, w>, index = [0]>, <position> dxsa.dcl_tgsm_raw <type = thread_group_shared_memory, components = 0, index = [0]>, 1024 Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
tagolog
force-pushed
the
dxsa-mlir-dcl_constant_buffer-and-other-ops
branch
from
f593309 to
62108d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.