Feature 634 - Map Widgets Alignment#655
Conversation
|
Hey, nice work on this — the panel-wrapper standardization and CSS variable cleanup is a big improvement, and snap-to-grid is a great addition. Two bugs in makeDraggable.js need fixing before I can merge though: Bug 1: The mousemove handler lost the if (!didDrag && (Math.abs(e.clientX - startX) > 2 || Math.abs(e.clientY - startY) > 2)) {
didDrag = true;
}Without this, Bug 2: Mousedown sets Also two minor nits (non-blocking):
Everything else looks good — the panel-wrapper DOM pattern, the options object API for makeDraggable, the CSS variable theming, and the proximity panel transform workaround all make sense. Should be a quick fix, let me know when it's updated! |
…ccius#655. Found an issue with the panel header not using the correct cursors due to multiple elements being set as drag handles, fixed issue between addMinimizeToggle.js and makeDraggable.js conflicts, moved styles to main.css as appropriate and replaced hard-coded colors
margin on draggable container
lightning to work with new draggable panels; refactored muf map to use theme colors and align with code in other layers
…ccius#655. Found an issue with the panel header not using the correct cursors due to multiple elements being set as drag handles, fixed issue between addMinimizeToggle.js and makeDraggable.js conflicts, moved styles to main.css as appropriate and replaced hard-coded colors
|
@accius Updates have been made to address the issues you identified plus... Found an issue with the panel header not using the correct cursors due to multiple elements being set as drag handles. Fixed issue between addMinimizeToggle.js and makeDraggable.js conflicts. Moved styles to main.css as appropriate and replaced hard-coded colors. The minimize toggle carat had different visual dimensions (as the Unicode characters are not the same dimensionally), so while I was in there, I moved to applying a rotation translation instead of swapping the characters. Sorry if that causes more work in reviewing the PR. |
|
looks good to merge, thanks! |
What does this PR do?
This PR affects all draggable map layers.
Layers updated...
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
BEFORE
AFTER
This PR addresses issue #634 .