Skip to content

[BUG 673] PSKReporter Always Uses FN31 as Grid Square#681

Merged
accius merged 1 commit intoaccius:Stagingfrom
alanhargreaves:locator-fix
Mar 7, 2026
Merged

[BUG 673] PSKReporter Always Uses FN31 as Grid Square#681
accius merged 1 commit intoaccius:Stagingfrom
alanhargreaves:locator-fix

Conversation

@alanhargreaves
Copy link
Copy Markdown
Collaborator

@alanhargreaves alanhargreaves commented Mar 6, 2026

What does this PR do?

Addresses #673

Updates SettingsPanel so that any update to the local "grid" variable results in an update to config.locator. Other functions (e.g. PSKFilterManager) pull the grid from config.locator, and as such were pulling a (very) incorrect value.

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

How to test

  1. Go to the PSKFilterManager
  2. Select "Source"
  3. My Grid Square should be correct

Checklist

  • App loads without console errors
  • [N/A] Tested in Dark, Light, and Retro themes
  • [N/A] Responsive at different screen sizes (desktop + mobile)
  • [N/A] If touching server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)
  • [N/A] If adding an API route: includes caching and error handling
  • [N/A] If adding a panel: wired into Modern, Classic, and Dockable layouts
  • [N/A] No hardcoded colors — uses CSS variables (var(--accent-cyan), etc.)
  • [N/A] No .bak, .old, console.log debug lines, or test scripts included

… as otehr code (eg PSKFilterManager) relies on it.
@alanhargreaves
Copy link
Copy Markdown
Collaborator Author

If someone could actually run through that test sequence for me before merge, I would appreciate it. By the time I got to the fix that would correct config.locator on load of the settings panel, I had already corrected it in my saved settings. Looking at the code, whether or not isOpen is true, it should ru the code that fixes the locator if the lat/lon is set.

@accius
Copy link
Copy Markdown
Owner

accius commented Mar 7, 2026

merging to staging we can test there.

@accius accius merged commit 14d9290 into accius:Staging Mar 7, 2026
@alanhargreaves alanhargreaves deleted the locator-fix branch March 7, 2026 08:10
@joenelis
Copy link
Copy Markdown

I tested this by downloading the files in the branch . . ./test/Staging into a new test subdirectory on my Linux machine. When I stared the system, my callsign and my grid square were already known - so this was not really a 'new install' where I would have had to start by entering that data .

I did steps 1, 2, 3 above. My Grid Square is now correctly shown in the PSK Filter Manager. I am able to select my Grid Square. And I see the Activity in and out of from my Grid Square as expected. While I did not methodically regression test the entire system, I did not see any obvious issues, Bug 673 may be closed.

@joenelis
Copy link
Copy Markdown

Correction I got the files from . . . . /tree/Staging

@joenelis
Copy link
Copy Markdown

I also tested changing my Grid Square in the Main Settings Menu From PA to FL to verify that the new Grid Square I typed in followed me to the PSKReporter Filter Menu. It did. And the [DE] circle on the map also moved to that new FL Grid Square. All is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants