[BUG 695] Lightning layer is not using settable distance units#697
Merged
accius merged 1 commit intoaccius:Stagingfrom Mar 10, 2026
Merged
[BUG 695] Lightning layer is not using settable distance units#697accius merged 1 commit intoaccius:Stagingfrom
accius merged 1 commit intoaccius:Stagingfrom
Conversation
…than just km. All comparisons are still done in km, but we display in the appropriate unit. I also had to update the panel header to list the strike radius in both units, in order to have this fit, i had to override the font size down to 11px.
Owner
|
Approve with minor fixes. Good change overall, distances now respect unit preferences cleanly. Three small things: Line 835 still passes // current
const distance = calculateDistance(stationLat, stationLon, strike.lat, strike.lon, 'km');
// should be
const distance = calculateDistance(stationLat, stationLon, strike.lat, strike.lon);The nearby strikes header crams both units in and shrinks the font to compensate. Since // current
`📍 Nearby Strikes(30km/18.6miles)`
// cleaner
`📍 Nearby Strikes (${allUnits.dist === 'metric' ? '30 km' : '18.6 mi'})`Same applies to the "No strikes within 30km (18.6 miles)" string further down. Also missing a space before the parenthesis in |
Collaborator
Author
|
I tried that. It doesn't work as it's only evaluated when the Panel is created. If you change units, it doesn't change with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated to use the global
allUnits.distfor 'metric' vs 'imperlal' for distance display.All comparisons are still done in km, but we display in the appropriate unit.
I also had to update the panel header to list the strike radius in both units, in order to have this fit, i had to override the font size down to 11px.
Addresses #695
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
Before:

After:
