[refactor / language] add missing keys, minor thai update#837
[refactor / language] add missing keys, minor thai update#837accius merged 16 commits intoaccius:Stagingfrom
Conversation
feat: unified cloud relay — carries decodes from all digital mode plu…
accius
left a comment
There was a problem hiding this comment.
Thanks for the key sorting and missing key additions Michael — the Thai translation looks good too. Found two issues that would silently regress existing translations:
1. Duplicate keys overwrite existing translations — ca, de, es, fr
These four languages already have translated values for pttDisabled and unauthorized. The PR adds English fallbacks for those same keys later in the file, creating duplicates. Most JSON parsers take the last value, so the existing translations get silently replaced with English.
Example from ca.json:
"app.rigControl.error.pttDisabled": "El PTT està desactivat al rig-bridge — ...", // existing Catalan ✓
"app.rigControl.error.unauthorized": "Error d'autenticació — ...", // existing Catalan ✓
"app.rigControl.error.notReachable": "Rig Bridge is not running — ...", // NEW — correct ✓
"app.rigControl.error.pttDisabled": "PTT is disabled on rig-bridge — ...", // DUPLICATE — overwrites Catalan ✗
"app.rigControl.error.unauthorized": "Unauthorized — check API token in ...", // DUPLICATE — overwrites Catalan ✗Same in de.json, es.json, fr.json. Fix: remove the duplicate pttDisabled and unauthorized lines from these four files — only notReachable needs to be added.
2. Duplicate skimmers key in ka.json (Georgian)
The file already has "plugins.layers.rbn.skimmers": "სკიმერები" and the PR adds a second "plugins.layers.rbn.skimmers": "Skimmers" which would overwrite the Georgian translation. Remove the English duplicate.
|
updated |
What does this PR do?
lang sort keys, add missing, minor update th
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)