Skip to content

[refactor / language] add missing keys, minor thai update#837

Merged
accius merged 16 commits intoaccius:Stagingfrom
MichaelWheeley:feature/thai-language-dev
Mar 27, 2026
Merged

[refactor / language] add missing keys, minor thai update#837
accius merged 16 commits intoaccius:Stagingfrom
MichaelWheeley:feature/thai-language-dev

Conversation

@MichaelWheeley
Copy link
Copy Markdown
Contributor

What does this PR do?

lang sort keys, add missing, minor update th

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

How to test

Checklist

  • App loads without console errors
  • Tested in Dark, Light, and Retro themes
  • Responsive at different screen sizes (desktop + mobile)
  • If touching server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)
  • If adding an API route: includes caching and error handling
  • If adding a panel: wired into Modern, Classic, and Dockable layouts
  • No hardcoded colors — uses CSS variables (var(--accent-cyan), etc.)
  • No .bak, .old, console.log debug lines, or test scripts included

Screenshots (if visual change)

@MichaelWheeley MichaelWheeley changed the title Feature/thai language dev [refactor / language] add missing keys, minor thai update Mar 25, 2026
feat: unified cloud relay — carries decodes from all digital mode plu…
Copy link
Copy Markdown
Owner

@accius accius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the key sorting and missing key additions Michael — the Thai translation looks good too. Found two issues that would silently regress existing translations:

1. Duplicate keys overwrite existing translations — ca, de, es, fr

These four languages already have translated values for pttDisabled and unauthorized. The PR adds English fallbacks for those same keys later in the file, creating duplicates. Most JSON parsers take the last value, so the existing translations get silently replaced with English.

Example from ca.json:

"app.rigControl.error.pttDisabled": "El PTT està desactivat al rig-bridge — ...",   // existing Catalan ✓
"app.rigControl.error.unauthorized": "Error d'autenticació — ...",                    // existing Catalan ✓
"app.rigControl.error.notReachable": "Rig Bridge is not running — ...",               // NEW — correct ✓
"app.rigControl.error.pttDisabled": "PTT is disabled on rig-bridge — ...",            // DUPLICATE — overwrites Catalan ✗
"app.rigControl.error.unauthorized": "Unauthorized — check API token in ...",         // DUPLICATE — overwrites Catalan ✗

Same in de.json, es.json, fr.json. Fix: remove the duplicate pttDisabled and unauthorized lines from these four files — only notReachable needs to be added.

2. Duplicate skimmers key in ka.json (Georgian)

The file already has "plugins.layers.rbn.skimmers": "სკიმერები" and the PR adds a second "plugins.layers.rbn.skimmers": "Skimmers" which would overwrite the Georgian translation. Remove the English duplicate.

@MichaelWheeley MichaelWheeley marked this pull request as draft March 26, 2026 15:12
@MichaelWheeley MichaelWheeley marked this pull request as ready for review March 26, 2026 15:21
@MichaelWheeley MichaelWheeley requested a review from accius March 26, 2026 15:23
@MichaelWheeley
Copy link
Copy Markdown
Contributor Author

updated

@accius accius merged commit dcd7ec3 into accius:Staging Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants