Support remarkable plugins and filtering the remarkable output#1
Closed
secobarbital wants to merge 6 commits intoacdlite:masterfrom
Closed
Support remarkable plugins and filtering the remarkable output#1secobarbital wants to merge 6 commits intoacdlite:masterfrom
secobarbital wants to merge 6 commits intoacdlite:masterfrom
Conversation
|
LGTM |
|
👍 |
|
@acdlite is there anything stopping this from being merged? anything i can help with? |
Collaborator
|
Just got commit access to clean the repo up a bit. Since it's quite old, I'll close this PR for now. If you're still interested in this patch it'd be great to get a new PR up with the ES6 syntax and conflicts removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, this would allow the use of
remarkableplugins likeremarkable-emojiand passing the rendered output through transforms liketwemoji. The latter is useful because it is otherwise hard to change the output set indangerouslySetInnerHTML.