use div for surrounding parsed content.#25
Closed
mightyplow wants to merge 1 commit intoacdlite:masterfrom
mightyplow:patch-1
Closed
use div for surrounding parsed content.#25mightyplow wants to merge 1 commit intoacdlite:masterfrom mightyplow:patch-1
mightyplow wants to merge 1 commit intoacdlite:masterfrom
mightyplow:patch-1
Conversation
|
better still would be to make this an option/prop on the |
davidowens
pushed a commit
to davidowens/react-remarkable
that referenced
this pull request
Nov 5, 2017
davidowens
pushed a commit
to davidowens/react-remarkable
that referenced
this pull request
Nov 5, 2017
|
As #33 allows container tag to be specified as a prop, I suggest closing this PR. |
Author
|
Hi,
as I understood it, there is now a prop for setting the content wrapper,
isn't it?
Cheers,
mightyplow
Beau Smith <notifications@github.com> schrieb am Di., 7. Aug. 2018, 20:53:
… @mightyplow <https://github.com/mightyplow> But, if you're going to close
this issue… merge #33
<#33> yo! 👯
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCvza6Arqedyh0MDXGIj2sIk23br0kJks5uOeI7gaJpZM4OOCuW>
.
|
|
I replied, thinking the repo owner closed this issue. Then deleted my
comment after realizing my mistake.
Please add your support to Issue #33 so that we can get that feature merged
by @acdlite!
…On Tue, Aug 7, 2018 at 21:07 mightyplow ***@***.***> wrote:
Hi,
as I understood it, there is now a prop for setting the content wrapper,
isn't it?
Cheers,
mightyplow
Beau Smith ***@***.***> schrieb am Di., 7. Aug. 2018, 20:53:
> @mightyplow <https://github.com/mightyplow> But, if you're going to
close
> this issue… merge #33
> <#33> yo! 👯
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#25 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABCvza6Arqedyh0MDXGIj2sIk23br0kJks5uOeI7gaJpZM4OOCuW
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABvHEb_25HfBs5BdVa6-0Vjf3Kb6f75ks5uOeWAgaJpZM4OOCuW>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #24