Skip to content

Conversation

@PabstMirror
Copy link
Contributor

No description provided.

Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, only issues are nitpicks


if (!hasInterface) exitWith {};

["ACE3 Weapons", QGVAR(cycleFireMode), LLSTRING(CycleFireMode), {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a keybind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should already handle player and vehicle weapons, as long as they have different fire-modes / useModeForAttackProfile
but we can always move it over if we find a need

@PabstMirror PabstMirror added this to the 3.20.0 milestone May 6, 2025
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 6, 2025
PabstMirror and others added 2 commits May 6, 2025 11:11
@PabstMirror PabstMirror merged commit f78ca32 into master May 7, 2025
3 checks passed
@PabstMirror PabstMirror deleted the missileCommonKeys branch May 7, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants