Skip to content

Conversation

@PabstMirror
Copy link
Contributor

No description provided.

@PabstMirror PabstMirror added this to the Ongoing milestone Jun 24, 2025
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jun 24, 2025
@Drofseh
Copy link
Contributor

Drofseh commented Jun 25, 2025

This gets the distance at time of death which may give a much shorter or longer distance for kills compared to the distance when the shot was fired.
For example, if the target is hit and goes uncon but takes a while to bleed out and the shooter moves up, or for shots from fast moving players such as pilots.
Do we care about these edge cases?

@PabstMirror PabstMirror changed the title Kill Tracker - Add distance to kill event Kill Tracker - Add unit object to kill event params Jun 26, 2025
@PabstMirror
Copy link
Contributor Author

I guess we would need to save the distance whenever we get an incoming wound
I don't really need this level
So I'll just send the unit object in the event

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.20.0 Jun 26, 2025
@PabstMirror PabstMirror added impact/trivial kind/change Release Notes: **CHANGED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Jul 6, 2025
@PabstMirror PabstMirror merged commit e6dff04 into master Jul 6, 2025
3 checks passed
@PabstMirror PabstMirror deleted the killEventsDistnace branch July 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/trivial kind/change Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants