Skip to content

Conversation

@lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Oct 20, 2025

When merged this pull request will:

  • Changes advanced throwing to use granular steps, currently 6 between the current toss and full throw using the scroll wheel.
    • Scroll wheel steps the between the min and max with CBA_events_shift + scroll wheel snapping between just the two extremes.

Feedback Requested

  • The original value of THROW_MODIFER_STEP allowed for 11 steps (shown in video on ACE discord) between two extremes (0.2), currently implemented with 6 steps. Would 11 steps be desirable?
  • Currently if you hold shift it switches between the two extremes (similar to current usage), should it be shift to enable granular mode for backwards compatibility (fewer would notice the ability to granularity change throw).

TO-DO

  • Add Shift + Scroll Wheel context hint.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@lambdatiger lambdatiger changed the title advanced_throwing - Granular Throw advanced_throwing - Add Granular Throw Oct 20, 2025
@lambdatiger
Copy link
Contributor Author

Modified stringtable, will need more to provide context about shift:
image
Alternatively, the shift modifier can be added below.

@Drofseh
Copy link
Contributor

Drofseh commented Oct 21, 2025

I think I'd prefer something like Power instead of Mode given all the steps, and it's definitely getting a little long.

Maybe split it into two?

[MMB_Icon] (Scroll) Change Throw Power / (Click) Cook
[MMB_Icon] (Scroll + %1) Min/Max Throw Power

Be sure to clear the translations as well so people know it needs to be redone.

@lambdatiger
Copy link
Contributor Author

lambdatiger commented Oct 21, 2025

I think I'd prefer something like Power instead of Mode given all the steps, and it's definitely getting a little long.

Maybe split it into two?

[MMB_Icon] (Scroll) Change Throw Power / (Click) Cook
[MMB_Icon] (Scroll + %1) Min/Max Throw Power

That's what I originally intended, but the mouse hint system doesn't work like that (it could, but I haven't checked to see if that breaks anything). The right mouse button reserves the space below and extra inputs are listed thereafter as just text, although jamming an image in isn't outside the realm of possibilities. I'll think of a way to make it look nice and commit to that.

Be sure to clear the translations as well so people know it needs to be redone.

Will do.

@Drofseh
Copy link
Contributor

Drofseh commented Oct 22, 2025

I think I'd prefer something like Power instead of Mode given all the steps, and it's definitely getting a little long.
Maybe split it into two?

[MMB_Icon] (Scroll) Change Throw Power / (Click) Cook
[MMB_Icon] (Scroll + %1) Min/Max Throw Power

That's what I originally intended, but the mouse hint system doesn't work like that (it could, but I haven't checked to see if that breaks anything). The right mouse button reserves the space below and extra inputs are listed thereafter as just text, although jamming an image in isn't outside the realm of possibilities. I'll think of a way to make it look nice and commit to that.

Be sure to clear the translations as well so people know it needs to be redone.

Will do.

If you can get it working that'd be great, otherwise maybe
[MMB_Icon] (Scroll) Throw Power / (Scroll + %1) Min/Max / (Click) Cook

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 22, 2025
@lambdatiger
Copy link
Contributor Author

Managed to get extra inline image to work without breaking backwards compatibility. I think Pabst's idea is also better for other reasons (ability to preserve current experience), do you want that instead or as well?

@PabstMirror PabstMirror added this to the 3.20.1 milestone Oct 30, 2025
@PabstMirror PabstMirror added the status/added-to-RC Added after RC, need to manually add to changelog label Oct 30, 2025
@PabstMirror
Copy link
Contributor

I think having both would be fine,
and we don't need the setting it was just an idea.

@PabstMirror PabstMirror merged commit b9ea3ac into acemod:master Nov 7, 2025
3 checks passed
@PabstMirror PabstMirror added kind/feature Release Notes: **ADDED:** and removed status/added-to-RC Added after RC, need to manually add to changelog kind/enhancement Release Notes: **IMPROVED:** labels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Release Notes: **ADDED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants