-
Notifications
You must be signed in to change notification settings - Fork 748
Medical - Add API to directly add wounds to units #11211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Pretty sure API go in |
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
| * 2.0: Wound Type <STRING> | ||
| * 2.1: Amount <NUMBER> | ||
| * 2.2: Size (0 - 2) <NUMBER> | ||
| * 2.3: Wound Damage <NUMBER> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This some new styling choice? I haven't seen any other ace function do this. They're always:
/*
* 0: Whatever <ARRAY>
* 0: Foo <...>
* 1: Bar <...>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a subset of a param, so it made sense to make it still contain the number of the param
| _createdWounds = true; | ||
| _bodyPartVisParams set [[1,2,3,3,4,4] select _bodyPartNToAdd, true]; | ||
| if (_createdWounds) then { | ||
| _unit setVariable [VAR_OPEN_WOUNDS, _openWounds, true]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we always want to sync this, even if just merging into an existing wound?
If we don't sync then the bleeding local players sees is different from what remote players see for them?
I know this is based on https://github.com/acemod/ACE3/blob/master/addons/medical_damage/functions/fnc_woundsHandlerBase.sqf#L199 so I'm worried it effects that as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its being merged with an old one, there will already be bloody clothing, so there's no need to update it
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.