Added VON GameProperties #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add options for customizing VONDisableUI, VONDisableDirectSpeechUI, and VONCanTransmitCrossFaction in the environment.
BrettMayson
approved these changes
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring three Voice Over Network (VON) game properties through environment variables: VONDisableUI, VONDisableDirectSpeechUI, and VONCanTransmitCrossFaction. These settings allow server administrators to control voice chat UI visibility and cross-faction communication capabilities.
Key changes:
- Added three new environment variables for VON configuration with default values of
false - Implemented logic to read these environment variables and apply them to the game configuration
- Updated default JSON configuration to include the new VON properties
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| launch.py | Added conditional logic to read VON-related environment variables and populate gameProperties configuration |
| docker_default.json | Added default VON property values to the base game configuration |
| Dockerfile | Defined three new environment variables for VON settings with false defaults |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #57 by adding environment variables to configure VONDisableUI, VONDisableDirectSpeechUI, and VONCanTransmitCrossFaction.