Fix getDefaultServerBaseUrl#17
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSimplified the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hm, this shouldn't be needed for farfield.app either. I'm not sure how this slipped in, sorry for missing it |
I think there is a breaking change for some setups introduced in 95379bd
Since this commit, browser defaults to 4311 on non-local ports. If you just run a simple port tunnel via Cloudflare or whatever - this will result in your hosted app trying to connect to
yourdomain.com:4311for api calls, which is not going to workI'm not sure how important are those lines for the working of http://farfield.app, but I'm just going to leave it there for now as it's the only way I was able to continue using the app remotely
Summary by CodeRabbit