Conversation
|
A few comments:
|
|
Thanks for the feedback! I think we need 1.92 in order to check the crates on CI, but we should still be able to keep the MSRV on 1.60. Let me try! |
|
I've confirmed that All your other concerns have been addressed too |
|
All I really set out to do was update to |
|
Would you like me to split this into smaller PRs? |
|
I switched to this PR's branch and had problems with dependecy versions being too strict, cargo couldn't select proper versions. I changed this to and also changed others to not contain patch versions and now it works. |
|
I'm sorry for the delay, I've been very busy professionally and I don't really use rust anymore on a day-to-day basis. I reviewed more carefully and I have a few questions:
|
Update MSRV to 1.92AddCargo.lockto git (for reproducible builds)rust-toolchain.toml