Dockerized Services #26
Conversation
docker-compose.yml
Outdated
| - groot-events-service | ||
| - groot-users-service | ||
| - groot-groups-service | ||
| - groot-quotes-service |
There was a problem hiding this comment.
not entirely sure what depends_on does but are these the correct service dependencies?
There was a problem hiding this comment.
depends_on just specifies the startup order of services
| - groot | ||
| restart: always | ||
|
|
||
| volumes: |
There was a problem hiding this comment.
Where do log files go? like the access_log also I would eventually like to move towards log files
There was a problem hiding this comment.
I can make a volume for log files. We also can grab the logs of each service through docker logs
There was a problem hiding this comment.
OK, this is setup now, assuming we use the config defaults I added to groot-api-gateway: https://github.com/acm-uiuc/groot/blob/4a1ed0def4570d09d9b8bd7839d58b74842d30fd/README.md#config-values
docker-compose.yml
Outdated
| - "3306:3306" | ||
| restart: always | ||
|
|
||
| groot: |
There was a problem hiding this comment.
This should probably be changed to groot-api-gateway
| @@ -1,6 +1,10 @@ | |||
| CREATE DATABASE IF NOT EXISTS groot_caffeine_service_dev; | |||
There was a problem hiding this comment.
is there a separate setup for prod dbs?
There was a problem hiding this comment.
I think we're currently running services with the _dev suffix in prod...
I guess it could be worth making the _dev and _prod databases in this script, though I'm not sure the _prod databases are enumerated anywhere.
There was a problem hiding this comment.
Yeah I was just following a convention of a _dev suffix for development environments and just the service name with no suffix for prod (at least for ruby services).
docker-compose.yml
Outdated
| ports: | ||
| - "8000:8000" | ||
| volumes: | ||
| - groot_api_gateway_volume:/var/groot/ |
There was a problem hiding this comment.
does the /var/groot need to change as well?
|
In this PR can you also include the readme updates for the preferred development and deployment instructions (since there are theoretically 3 options)? |
|
Also docker_settings_init.sh needs to be updated (both to match arbor and the new docker urls) |
|
I'm inclined to make the singular docker container deployment method unsupported. It's just not a good solution. This would make docker_settings_init obsolete. |
|
Sounds good |
|
Well actually it might be useful for setting up non docker setups if we want to continue to support that, since it creates the config files |
|
Perhaps that and the documentation surrounding non-docker development if that is going to be a secondary way of working should be moved to a wiki on this repo |
narendasan
left a comment
narendasan
left a comment
There was a problem hiding this comment.
Looks fine, modify the documentation as needed before merge (so new devs can get going) and are we going to change the db setup stuff?
Changing docker setup to have each service/client in its own Docker container.