Fixes to run on current Node.js versions and handle crash reports from current clients#31
Merged
Jimbly merged 7 commits intoacrisci:masterfrom Dec 20, 2024
Merged
Conversation
Fixes two 'finish' events emitted when handling uploads from Electron/crashpad, causing "headers already sent" error (which was showing up as "[Object object]" in the console
Includes update to minidump@0.22 to support Node 22.x+ Includes not-yet-merged PRs to fix: Fixes callback being called multiple times upon error Fixes failing to install outside of git repositories or if yarn is not installed Allow installation on Windows again Includes pre-built (albeit old) Win32 binaries for Windows (Linux binaries only) Uses latest breakpad version to support parsing dumps sent from Windows 11 22H2 clients
…od set of dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes I needed to make as I updated my servers from Node 16 to Node 22, and added an Electron-based client submitting crash reports (uses crashpad, not breakpad, on the front end, which shouldn't matter, but apparently hit some bug in
busboy).minidumpwith@jimbly/minidumpminidump_stackwalkfails to executeAs of this update, I'm running the latest version here in production on a Node v22.12.0 server, with a
sqlitedatabase backend, and successfully receiving crash reports from older breakpad and Electron/crashpad clients (and, very importantly, actually getting useful callstacks from those old clients when running on Windows 11 which apparently broke some months ago due to an dbghelp.dll update in Windows, although the dumps were still valid and debuggable, of course).