Skip to content

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented May 6, 2021

closes #40

@sbidoul sbidoul marked this pull request as draft May 6, 2021 08:37
@sbidoul sbidoul force-pushed the registry-signaling branch from 21d2283 to b4ca949 Compare May 9, 2021 16:40
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #41 (b4ca949) into master (b65f976) will decrease coverage by 6.17%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   83.85%   77.67%   -6.18%     
==========================================
  Files           6        6              
  Lines         223      224       +1     
  Branches       31       31              
==========================================
- Hits          187      174      -13     
- Misses         25       39      +14     
  Partials       11       11              
Impacted Files Coverage Δ
click_odoo/env.py 56.09% <63.15%> (-16.41%) ⬇️
click_odoo/env_options.py 87.37% <0.00%> (-6.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b65f976...b4ca949. Read the comment docs.

@sbidoul sbidoul force-pushed the registry-signaling branch 2 times, most recently from 456529e to 7279669 Compare August 20, 2025 10:36
@legalsylvain
Copy link
Contributor

Hi @sbidoul. still draft ?

Regards.

@sbidoul sbidoul force-pushed the registry-signaling branch from 7279669 to 0a803ff Compare October 13, 2025 08:06
@sbidoul
Copy link
Member Author

sbidoul commented Oct 13, 2025

I worried that the failing test was revealing a connection leak... now it's failing for Odoo 11 only, so we may want to drop official support for that old Odoo.

@legalsylvain
Copy link
Contributor

now it's failing for Odoo 11 only, so we may want to drop official support for that old Odoo.

Dropping official support doesn't mean it doesn't work , but only that we will not ensure it is working. So maybe it's acceptable to drop it.
I'm too newb in this lib to have a clear opinion on that topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support registry database signaling to

4 participants