Fix dind sidecar template

[mhuijgen]

This PR fixes the helm template issue when containerMode is not set to dind so it does not add the dind sidecar because of a incorrectly placed {{ end }}

As well a fix to the values file to add the missing volumeMounts for the dind sidecar container template which the helm template does add in case of type "dind"

Fixes #4125 #4127

[Copilot]

Pull Request Overview

This PR fixes a Helm template issue where an incorrectly placed closing conditional caused the dind sidecar to be added even when not intended, and updates the values file with commented examples for the missing volumeMounts for the dind sidecar container template.

• Fixed the misplaced "{{- end }}" in the autoscalingrunnerset.yaml to properly close the dind-related block.
• Added commented sample volumeMounts in values.yaml for guidance on configuring the dind sidecar.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
charts/gha-runner-scale-set/values.yaml	Added commented volumeMounts examples for the dind sidecar template.
charts/gha-runner-scale-set/templates/autoscalingrunnerset.yaml	Adjusted conditional block closure to fix the dind sidecar inclusion.

Comments suppressed due to low confidence (2)

charts/gha-runner-scale-set/values.yaml:332

• [nitpick] If these commented volumeMounts are meant to be used for configuring the dind sidecar, consider adding a clarifying note or uncommenting them to avoid potential confusion.

##       volumeMounts:

charts/gha-runner-scale-set/templates/autoscalingrunnerset.yaml:174

• Ensure that this newly added end block correctly closes the intended 'if' section without affecting surrounding logic. Verify that the conditionals render properly when containerMode is not set to 'dind'.

{{- end }}

[nikola-jokic]

Thank you!