RunnerSet: Automatic-recovery from registration timeout and deregistration on pod termination #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the automatic recovery feature from registration timeouts and the runner deregistration on pod termination feature to RunnerSets added in #629.
You don't need any extra configuration to RunnerSet.Spec to leverage this feature. Just deploy a runnerset like shown in #629 and #647 and the new
runnerpod-controllerdoes the job for you.I've also conducted a bit more manual tests and it turned out it works quite reliably with both ephemeral and non-epehemral runners. Beware that trying to change
ephemeralfromfalsetotruewhile running jobs may result in jobs remain pending forever. Probably that's due to how GitHub API and GitHub runners work. If you want to change theephemeralfield, I'd highly recommend you to recreate RunnerSet.Ref #629
Ref #613
Ref #612