fix ref for pr closed event when a pr is merged#141
Merged
ericsciple merged 3 commits intomasterfrom Jan 21, 2020
Merged
Conversation
ericsciple
commented
Jan 21, 2020
| if (isWorkflowRepository) { | ||
| result.ref = github.context.ref; | ||
| result.commit = github.context.sha; | ||
| // Some events have an unqualifed ref. For example when a PR is merged (pull_request closed event), |
Contributor
Author
There was a problem hiding this comment.
@andymckay is this a bug on the server? Seems like github.ref would always be qualified (e.g. refs/heads/master not master). For most events it's qualified. PR closed_event (when a PR is merged) is the only case I'm aware it's not.
I'm still planning to proceed with this fix here for resiliency, but just FYI since this seems like a bug on the server.
TingluoHuang
approved these changes
Jan 21, 2020
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #136