Update/Add Ninja

[compnerd]

Tool information

• Tool name: Ninja
• Add or update? Add
• Desired version: latest
• Approximate size:
• If this is an add request:
  • Brief description of tool: ninja is a build tool focused on speed
  • URL for tool's homepage: https://github.com/ninja-build/ninja

Area for Triage:
Packages

Question, Bug, or Feature?:
Feature

Virtual environments affected

• macOS 10.15
• Ubuntu 16.04 LTS
• Ubuntu 18.04 LTS
• Windows Server 2016 R2
• Windows Server 2019

Can this tool be installed during the build?
Yes, the install is bound by download time (usually ~1m)

Are you willing to submit a PR?
Yes

[compnerd]

The ninja tool is already included in the Windows hosts via Visual Studio. It would be nice to include it on the macOS and Ubuntu VMs. For Ubuntu, apt-get install -y ninja-build is sufficient.

[miketimofeev]

Hi @compnerd! As I know ninja is installed along with vcpkg, here is the vcpkg installation log:

    azure-arm: Downloading ninja...
==> azure-arm:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
==> azure-arm:                                  Dload  Upload   Total   Spent    Left  Speed
==> azure-arm: 100   624  100   624    0     0   2034      0 --:--:-- --:--:-- --:--:--  2039
==> azure-arm: 100 99857  100 99857    0     0  99025      0  0:00:01  0:00:01 --:--:--  322k
    azure-arm: Downloading ninja... done.
    azure-arm: Extracting ninja...
    azure-arm: Extracting ninja... done.

I wonder if it could be used for your purposes?

[compnerd]

@miketimofeev interesting, ninja is definitely not found on the Linux builders (on Azure). I thought that the Azure and GitHub actions were merged into a single repository.

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
-- Configuring incomplete, errors occurred!
See also "/home/vsts/work/1/b/.../CMakeFiles/CMakeOutput.log".

[miketimofeev]

@compnerd Unfortunately, I'm not so familiar with CMake builds, but is it possible to use vcpkg for them?
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_configure_cmake.md

[compnerd]

@miketimofeev no, it is not possible to use vcpkg for building for my purposes. I need to be able to use ninja directly through CMake as that is the only way that you can build Swift packages with CMake. The projects only support CMake, and supporting vcpkg is not viable as adding yet another build system to projects is not likely to be accepted.

[compnerd]

@miketimofeev actually, thinking more about this - isn't this actually better? Adding ninja to the base image allows CMake to use it and vcpkg could use the host provided ninja builder as well.

[miketimofeev]

Oh, I see. Can that ninja from vcpkg be used directly from /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja?
We try to avoid tools duplicating, that's why I'm trying to find any possible ways.

[compnerd]

Hardcoding random paths doesn't work very well for the azure pipelines if you are using different builders. Can you not use ninja from /usr/bin/ninja instead of /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja?

Alternatively, you could symlink the path from /usr/bin/ninja.

[miketimofeev]

If this path works /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja then we can simply add a symlink

[compnerd]

Where the tool resides is not a big deal, if ninja can be added to the path for all the builders, that is perfectly acceptable (though beyond my ability to help with).

[miketimofeev]

Can you confirm that
sudo ln -s /usr/local/share/vcpkg/downloads/tools/ninja-1.10.0-linux/ninja /usr/local/bin/ninja solves your task?
If yes – we'll consider making the symlink during the vcpkg installation

[compnerd]

@miketimofeev nope, that still fails. I can verify that sudo apt-get install ninja-build does fix it though.