Virtual environment rebrand - readme updates #6006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted a test file I made
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
miketimofeev
reviewed
Aug 3, 2022
Contributor
|
@lkfortuna should we remove this doc as the readme now includes everything? |
Co-authored-by: Mikhail Timofeev <48208649+miketimofeev@users.noreply.github.com>
Contributor
Author
@miketimofeev Yes, agreed I will add to this PR |
Steve-Glass
requested changes
Aug 3, 2022
samvantran
reviewed
Aug 3, 2022
Contributor
samvantran
left a comment
samvantran
left a comment
There was a problem hiding this comment.
👍 couple comments but nice update!
samvantran
reviewed
Aug 3, 2022
Co-authored-by: Sam Tran <samvantran@github.com>
This reverts commit 9ff7d22.
lkfortuna
requested review from
Steve-Glass,
miketimofeev and
samvantran
and removed request for
miketimofeev
samvantran
approved these changes
Aug 5, 2022
Contributor
samvantran
left a comment
samvantran
left a comment
There was a problem hiding this comment.
Hope you don't mind but i pushed to your branch to fix the linter errors @lkfortuna
ddobranic
approved these changes
Aug 8, 2022
Steve-Glass
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update to the readme files adds a table of contents, organizes info by clearly define sections, bring to the forefront the image support policies, and adds an FAQ section.
It also updates any mentions of virtual environments to runner images.
Check list