Skip to content

Conversation

@seanyoung
Copy link

When specifying service containers for a jobs, sometimes it is necessary to add command line arguments to the container. See this example: https://github.bokerqi.topmunity/t/how-do-i-properly-override-a-service-entrypoint/17435. Here it is useful to add --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://0.0.0.0:2379 to the container start command line.

These arguments are simply passed after the image name on the docker create command line.

Here is another example of trying to add command line arguments to postgres: https://stackoverflow.com/questions/65438055/how-to-add-config-args-to-postgres-service-container-in-github-action

The options field cam be used to change the entrypoint of a container, but it is not possible to change the arguments.

Please let me know what else is required to make this mergable, thank you.

@seanyoung seanyoung requested a review from a team as a code owner June 12, 2021 10:32
@seanyoung
Copy link
Author

Another example is parity substrate. This container requires an argument, else an error is returned:

docker run --rm -it parity/substrate:latest
Error: Input("Please specify which chain you want to run, e.g. --dev or --chain=local")

vs

docker run --rm -it parity/substrate:latest --dev
2021-06-12 16:56:39  Running in --dev mode, RPC CORS has been disabled.    
2021-06-12 16:56:39  Substrate Node    
...

So without being able to add any arguments, it's impossible to have substrate as a service.

@abe-winter
Copy link

abe-winter commented Apr 27, 2024

bumping this in case it moves it up the queue

in many cases, the 'local emulator' image for key cloud services can only be configured with command line parameters. this is a primary use-case for the services feature of actions

a user can work around that by building their own image with an overridden CMD/ENTRYPOINT, but it would be so much better for actions to expose this ability directly; it is core docker functionality

there are multiple requests for this out in the wild:

gitlab has had this for decades: https://docs.gitlab.com/ee/ci/docker/using_docker_images.html#override-the-entrypoint-of-an-image

@Blizter
Copy link
Contributor

Blizter commented Sep 12, 2024

Hello,

Building, and Maintaining custom images everytime we want to pass a specific entrypoint is extremely painful.

Any news regarding the merge of this PR for passing custom CMD/entrypoints to container services?

@plutov
Copy link

plutov commented Nov 21, 2024

Hey,

any update on this? Service containers are unusable to me as is without being able to override CMD.

@rob-apella
Copy link

bump - is this good to go? lgtm

@mmizutani
Copy link

mmizutani commented Dec 9, 2024

@AllanGuigou @TingluoHuang @rentziass @benwells
Could you please assign a new reviewer for this highly anticipated but overlooked PR?
This PR requires re-approval for merge, but more than three years passed since the original reviewer approved this PR.

@jmalloc
Copy link

jmalloc commented Apr 2, 2025

Hi maintainers, is there any chance of this proceeding?

@jannes-io
Copy link

Need this to run mysql to change flags and configuration.

--sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION --group_concat_max_len=16384 --max_allowed_packet=512M

@FabioDavidF
Copy link

Bump.

The fact that this is not already merged is weird. Passing args to docker container entrypoints is a basic feature and expected to be available by very common docker images like mysql.

@soenneker
Copy link

@seanyoung Have you heard from the maintainers at all on this?

@jbebe
Copy link

jbebe commented Apr 25, 2025

Bumping because the Azurite image doesn't even work without passing --blobHost 0.0.0.0 to it.

@slavik-pastushenko
Copy link

Do you have any idea when it will be merged?

@rwojsznis
Copy link

Jesus, this PR is from 2021?

All_Right_Then,_Keep_Your_Secrets jpg

@lostzsh
Copy link

lostzsh commented Aug 4, 2025

Waiting for the merge

@dvaldivia
Copy link

it's approved, can this be merged?

@lostzsh
Copy link

lostzsh commented Aug 10, 2025

Where is the merged???

@0xmaiev
Copy link

0xmaiev commented Aug 10, 2025

Where is this merged???

@jaeyson
Copy link

jaeyson commented Aug 10, 2025

wow they probably had other reasons why this isn't merged yet

@ofirzyg
Copy link

ofirzyg commented Aug 26, 2025

merge this !!! much much needed!!

@jgnieuwhof
Copy link

Can we have any comment from the maintainers as to why this hasn't been merged?

It's such a basic use-case I'm shocked it wasn't in the initial release.

@aviallon
Copy link

Come on, I agree with the others, this is a trivial PR.

@soenneker
Copy link

soenneker commented Sep 11, 2025

@salmanmkc @ericsciple @TingluoHuang tagging for visibility

If not possible to merge in, perhaps we could get an explanation or we could seek changes?

Thanks

@stephen-totty-hpe
Copy link

It would be nice to get some feedback from maintainers on this PR

@petelah
Copy link

petelah commented Nov 24, 2025

This PR would greatly improve the usability of containerised services in github actions. Any maintainers in the chat?

@sodabrew
Copy link

sodabrew commented Jan 3, 2026

Happy New Year 2026!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.