Save record order for annotation links when creating issues#1744
Merged
TingluoHuang merged 3 commits intoactions:mainfrom Mar 14, 2022
Merged
Save record order for annotation links when creating issues#1744TingluoHuang merged 3 commits intoactions:mainfrom
TingluoHuang merged 3 commits intoactions:mainfrom
Conversation
TingluoHuang
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/c2c-actions-checks/issues/52
The end goal of this change is to be able to link annotations to exact step and log lines from the run summary page
Right now they just point to the log page but we want to expand the exact step and scroll to the exact line that each annotation originates from when clicked on. We have the line number already via
logFileLineNumberbut we also need to save the step informationTested this with
There was a potential problem with the timeline record order not being sequential so the numbers can go from something like
1,2,3,4,5,8,12,15. However this is not a concern and we can reliably use the timeline record order as the step number since we have the same information saved already when we render steps in the Actions UI.