Merged
Conversation
TingluoHuang
approved these changes
Oct 23, 2023
TingluoHuang
approved these changes
Oct 23, 2023
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2694, I updated Docker from
20.10to23.0, which was released in2.309.0.As mentioned at the top of the
23.0release notes here,buildxwas separated into a separate package in that release.As a result of this change, we started experiencing the
docker buildissue below on our self-hosted runners after we updated them to2.309.0:After further investigation, I noticed that
Docker-Buildxwas explicitly listed on theInstalled Packagessection of GitHub's runners below, which is likely why they weren't affected by this change:This PR installs
buildxinto theactions/runnerimages so that self-hosted runners can continue to function correctly.cc: @Link-, @TingluoHuang