Add codeload to the list of service we check during '--check'.#3011
Merged
TingluoHuang merged 1 commit intomainfrom Nov 28, 2023
Merged
Add codeload to the list of service we check during '--check'.#3011TingluoHuang merged 1 commit intomainfrom
TingluoHuang merged 1 commit intomainfrom
Conversation
rentziass
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to ensure the runner can access the GitHub codeload service and updates the documentation to reflect this requirement. The most important changes include adding a code block to check the accessibility of the codeload service in the
ActionsCheck.RunCheckmethod and updating theactions.mddocumentation file with instructions for testing the accessibility of the codeload service.Main code changes:
src/Runner.Listener/Checks/ActionsCheck.cs: Added a code block to check the accessibility of the GitHub codeload service in theActionsCheck.RunCheckmethod.Documentation updates:
docs/checks/actions.md: Updated theactions.mddocumentation file with instructions for testing the accessibility of the codeload service and mentioning the requirement for the runner to accesshttps://codeload.github.comfor downloading actions tar.gz/zip. [1] [2]docs/checks/actions.md: Added a new bullet point for GitHub Enterprise Server, mentioning the requirement for the runner to accesshttps://codeload.[hostname]/_ping.