Skip to content

Preserve dates when deserializing job message from Run Service#3269

Merged
ericsciple merged 2 commits intomainfrom
users/ericsciple/24-05-date
May 2, 2024
Merged

Preserve dates when deserializing job message from Run Service#3269
ericsciple merged 2 commits intomainfrom
users/ericsciple/24-05-date

Conversation

@ericsciple
Copy link
Copy Markdown
Collaborator

No description provided.

@ericsciple ericsciple marked this pull request as ready for review May 1, 2024 20:23
@ericsciple ericsciple requested a review from a team as a code owner May 1, 2024 20:23
}
}

protected override async Task<T> ReadJsonContentAsync<T>(HttpResponseMessage response, CancellationToken cancellationToken = default(CancellationToken))
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a virtual method on RawHttpClientBase

protected virtual async Task<T> ReadJsonContentAsync<T>(HttpResponseMessage response, CancellationToken cancellationToken = default(CancellationToken))

cancellationToken: cancellationToken);
}

protected override async Task<T> ReadJsonContentAsync<T>(HttpResponseMessage response, CancellationToken cancellationToken = default(CancellationToken))
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to isolate the change to this one call since this flow is controlled by a feature flag

@ericsciple ericsciple enabled auto-merge (squash) May 2, 2024 14:12
@ericsciple ericsciple merged commit 18803bd into main May 2, 2024
@ericsciple ericsciple deleted the users/ericsciple/24-05-date branch May 2, 2024 14:44
@crohr
Copy link
Copy Markdown

crohr commented May 3, 2024

@ericsciple could this explain issues with jobs not being picked up / picked up late? runs-on/runs-on#75

lumiere-bot bot referenced this pull request in coolguy1771/home-ops May 3, 2024
…16.1 ) (#4630)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/onedr0p/actions-runner](https://ghcr.io/onedr0p/actions-runner)
([source](https://togithub.com/actions/runner)) | patch | `2.316.0` ->
`2.316.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>actions/runner (ghcr.io/onedr0p/actions-runner)</summary>

###
[`v2.316.1`](https://togithub.com/actions/runner/releases/tag/v2.316.1)

[Compare
Source](https://togithub.com/actions/runner/compare/v2.316.0...v2.316.1)

##### What's Changed

- Preserve dates when deserializing job message from Run Service by
[@&#8203;ericsciple](https://togithub.com/ericsciple) in
[https://github.com/actions/runner/pull/3269](https://togithub.com/actions/runner/pull/3269)

**Full Changelog**:
actions/runner@v2.316.0...v2.316.1

*Note: Actions Runner follows a progressive release policy, so the
latest release might not be available to your enterprise, organization,
or repository yet.
To confirm which version of the Actions Runner you should expect, please
view the download instructions for your enterprise, organization, or
repository.
See
https://docs.github.com/en/enterprise-cloud@latest/actions/hosting-your-own-runners/adding-self-hosted-runners*

##### Windows x64

We recommend configuring the runner in a root folder of the Windows
drive (e.g. "C:\actions-runner"). This will help avoid issues related to
service identity folder permissions and long file path restrictions on
Windows.

The following snipped needs to be run on `powershell`:

```powershell

##### Create a folder under the drive root
mkdir \actions-runner ; cd \actions-runner

##### Download the latest runner package
Invoke-WebRequest -Uri https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-win-x64-2.316.1.zip -OutFile actions-runner-win-x64-2.316.1.zip

##### Extract the installer
Add-Type -AssemblyName System.IO.Compression.FileSystem ;
[System.IO.Compression.ZipFile]::ExtractToDirectory("$PWD\actions-runner-win-x64-2.316.1.zip", "$PWD")
```

##### \[Pre-release] Windows arm64

**Warning:** Windows arm64 runners are currently in preview status and
use [unofficial versions of
nodejs](https://unofficial-builds.nodejs.org/). They are not intended
for production workflows.

We recommend configuring the runner in a root folder of the Windows
drive (e.g. "C:\actions-runner"). This will help avoid issues related to
service identity folder permissions and long file path restrictions on
Windows.

The following snipped needs to be run on `powershell`:

```powershell

##### Create a folder under the drive root
mkdir \actions-runner ; cd \actions-runner

##### Download the latest runner package
Invoke-WebRequest -Uri https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-win-arm64-2.316.1.zip -OutFile actions-runner-win-arm64-2.316.1.zip

##### Extract the installer
Add-Type -AssemblyName System.IO.Compression.FileSystem ;
[System.IO.Compression.ZipFile]::ExtractToDirectory("$PWD\actions-runner-win-arm64-2.316.1.zip", "$PWD")
```

##### OSX x64

```bash

##### Create a folder
mkdir actions-runner && cd actions-runner

##### Download the latest runner package
curl -O -L https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-osx-x64-2.316.1.tar.gz

##### Extract the installer
tar xzf ./actions-runner-osx-x64-2.316.1.tar.gz
```

##### OSX arm64 (Apple silicon)

```bash

##### Create a folder
mkdir actions-runner && cd actions-runner

##### Download the latest runner package
curl -O -L https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-osx-arm64-2.316.1.tar.gz

##### Extract the installer
tar xzf ./actions-runner-osx-arm64-2.316.1.tar.gz
```

##### Linux x64

```bash

##### Create a folder
mkdir actions-runner && cd actions-runner

##### Download the latest runner package
curl -O -L https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-linux-x64-2.316.1.tar.gz

##### Extract the installer
tar xzf ./actions-runner-linux-x64-2.316.1.tar.gz
```

##### Linux arm64

```bash

##### Create a folder
mkdir actions-runner && cd actions-runner

##### Download the latest runner package
curl -O -L https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-linux-arm64-2.316.1.tar.gz

##### Extract the installer
tar xzf ./actions-runner-linux-arm64-2.316.1.tar.gz
```

##### Linux arm

```bash

##### Create a folder
mkdir actions-runner && cd actions-runner

##### Download the latest runner package
curl -O -L https://github.com/actions/runner/releases/download/v2.316.1/actions-runner-linux-arm-2.316.1.tar.gz

##### Extract the installer
tar xzf ./actions-runner-linux-arm-2.316.1.tar.gz
```

##### Using your self hosted runner

For additional details about configuring, running, or shutting down the
runner please check out our [product
docs.](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/adding-self-hosted-runners)

##### SHA-256 Checksums

The SHA-256 checksums for the packages included in this build are shown
below:

- actions-runner-win-x64-2.316.1.zip <!-- BEGIN SHA win-x64
-->e41debe4f0a83f66b28993eaf84dad944c8c82e2c9da81f56a850bc27fedd76b<!--
END SHA win-x64 -->
- actions-runner-win-arm64-2.316.1.zip <!-- BEGIN SHA win-arm64
-->3efe553a881f24eb20e79750033f69c23fcff35d78448aedf539f606cf9b869f<!--
END SHA win-arm64 -->
- actions-runner-osx-x64-2.316.1.tar.gz <!-- BEGIN SHA osx-x64
-->392b9d7b6d5b4d4f3814dbf874641b894f0c72447cdf05ce93158832d2d49b6b<!--
END SHA osx-x64 -->
- actions-runner-osx-arm64-2.316.1.tar.gz <!-- BEGIN SHA osx-arm64
-->75129881e1b80857d235d95a390106470536f5669354cb26af8651861398fa97<!--
END SHA osx-arm64 -->
- actions-runner-linux-x64-2.316.1.tar.gz <!-- BEGIN SHA linux-x64
-->d62de2400eeeacd195db91e2ff011bfb646cd5d85545e81d8f78c436183e09a8<!--
END SHA linux-x64 -->
- actions-runner-linux-arm64-2.316.1.tar.gz <!-- BEGIN SHA linux-arm64
-->4f506deac376013a95683fd5873e9c40f27e5790895147ccaa24d7c970532249<!--
END SHA linux-arm64 -->
- actions-runner-linux-arm-2.316.1.tar.gz <!-- BEGIN SHA linux-arm
-->534f210f1c854e24948ab9a263eb36797301946aba1760101ad96fc693873f43<!--
END SHA linux-arm -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzQuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMzNC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jun 17, 2025
…ns#3269)

* Preserve dates when deserializing job message from Run Service

* Preserve dates when deserializing job message from "Actions Run Service"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants