Skip to content

Cleanup back-compat code for interpreting Run Service status codes#3456

Merged
ericsciple merged 1 commit intomainfrom
users/ericsciple/24-09-cleanup
Sep 6, 2024
Merged

Cleanup back-compat code for interpreting Run Service status codes#3456
ericsciple merged 1 commit intomainfrom
users/ericsciple/24-09-cleanup

Conversation

@ericsciple
Copy link
Copy Markdown
Collaborator

No description provided.

@ericsciple ericsciple marked this pull request as ready for review September 6, 2024 18:28
@ericsciple ericsciple requested a review from a team as a code owner September 6, 2024 18:28
}

// Temporary back compat
switch (result.StatusCode)
Copy link
Copy Markdown
Collaborator Author

@ericsciple ericsciple Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested E2E to make sure everything is still working as expected. Specifically I tested the 422 UnprocessableEntity scenario above. Easy to repro that scenario via reusable workflow with a required secret, with the caller providing an expression that evaluates to empty/nil.

Copy link
Copy Markdown
Collaborator Author

@ericsciple ericsciple Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: CI
on:
  workflow_dispatch:
jobs:
  build:
    uses: ./.github/workflows/reuse.yml
    secrets: 
      foo: ${{ github.nosuch }}
# .github/workflows/reuse.yml

on:
  workflow_call:
    secrets:
      foo:
        description: asdf
        required: true
jobs:
  build:
    runs-on: self-hosted
    steps:
      - run: echo hi
        env:
          FOO_SECRET: ${{ secrets.foo }}

@ericsciple ericsciple force-pushed the users/ericsciple/24-09-cleanup branch from 010753b to b3de9de Compare September 6, 2024 21:40
@ericsciple ericsciple merged commit ddf41af into main Sep 6, 2024
@ericsciple ericsciple deleted the users/ericsciple/24-09-cleanup branch September 6, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants