Merged
Conversation
TingluoHuang
force-pushed
the
users/tihuang/dockerfile2
branch
from
5f92a1d to
b709a5b
Compare
ali-kafel
approved these changes
Oct 28, 2024
|
Could we get this approved and merged so that I may close out this PR: #3498 |
TingluoHuang
force-pushed
the
users/tihuang/dockerfile2
branch
2 times, most recently
from
d55cacb to
ed0e64d
Compare
TingluoHuang
commented
Nov 12, 2024
| @@ -1,12 +1,12 @@ | |||
| # Source: https://github.com/dotnet/dotnet-docker | |||
| FROM mcr.microsoft.com/dotnet/runtime-deps:6.0-jammy as build | |||
| FROM mcr.microsoft.com/dotnet/runtime-deps:8.0-jammy as build | |||
Member
Author
There was a problem hiding this comment.
the runner in latest main is dotnet 8.
TingluoHuang
commented
Nov 12, 2024
| # Configure git-core/ppa based on guidance here: https://git-scm.com/download/linux | ||
| RUN add-apt-repository ppa:git-core/ppa \ | ||
| && apt update -y \ | ||
| && apt install -y --no-install-recommends git |
Member
Author
There was a problem hiding this comment.
install recommends will have ssh installed, so customer can check out repository via ssh in actions/checkout
TingluoHuang
changed the title
TingluoHuang
force-pushed
the
users/tihuang/dockerfile2
branch
from
ed0e64d to
d669d42
Compare
Link-
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.