add github.url and github.api_url for ghes alpha#386
Conversation
| // Temporary hack for GHES alpha | ||
| var configurationStore = HostContext.GetService<IConfigurationStore>(); | ||
| var runnerSettings = configurationStore.GetSettings(); | ||
| if (!runnerSettings.IsHostedServer && !string.IsNullOrEmpty(runnerSettings.GitHubUrl)) |
There was a problem hiding this comment.
I think this needs to be string.IsNullOrEmpty(runnerSettings.GitHubUrl). This will be non-null if you're talking to hosted GitHub -- see where this is set.
There was a problem hiding this comment.
Or, is that supposed to be an || in the middle?
There was a problem hiding this comment.
good catch
@TingluoHuang when !runnerSettings.IsHostedServer should we fallback to runnerSettings.ServerUrl when GitHubUrl is not defined?
There was a problem hiding this comment.
runnerSettings.ServerUrl is the pipelines url, pipelines.actions.githubusercontent.com/xxxxx
When GitHubUrl is not defined, it means we connected to Devfabric.
There was a problem hiding this comment.
ok i think the change here might be fine then, but additional change to figure out for registration against the appliance
There was a problem hiding this comment.
discussed offline w/ ting, leaving this way for now. When config against appliance works, will need an additional change to persist githuburl for that scenario.
3 participants
For GHES alpha release, expose GHES server URL and API URL for actions (e.g. where checkout should clone from)