Improve logic around decide IsHostedServer.#4086
Merged
TingluoHuang merged 1 commit intomainfrom Oct 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the logic for determining whether a runner is operating on a hosted server by implementing a more sophisticated decision cascade in the IsHostedServer property getter.
Key Changes:
- Replaces simple null-coalescing logic with a three-tier fallback strategy
- Adds inference capability using
UrlUtil.IsHostedServer()when the property isn't explicitly set - Reorganizes imports to follow alphabetical ordering convention
luketomlinson
approved these changes
Oct 22, 2025
alinetskyi
pushed a commit
to CoreumFoundation/runner
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3326
Credit goes to @alixinne