Validate work dir during runner start up.#4227
Merged
TingluoHuang merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an early startup check in the listener to ensure the runner work directory exists and is accessible, so the runner can fail fast with a clear error rather than encountering later job/runtime failures.
Changes:
- Create the runner work directory (if needed) and validate directory access during
Runner.RunAsyncstartup. - Log validation progress/failure and terminate early on validation errors.
- Remove an unused
usingand normalize some whitespace.
TingluoHuang
force-pushed
the
users/tihuang/validatedir
branch
from
ca705c9 to
8936191
Compare
Contributor
|
@TingluoHuang I've opened a new pull request, #4228, to work on those changes. Once the pull request is ready, I'll request review from you. |
TingluoHuang
force-pushed
the
users/tihuang/validatedir
branch
from
8936191 to
7b47280
Compare
TingluoHuang
commented
Feb 9, 2026
Member
Author
There was a problem hiding this comment.
hide whitespace for better diff.
rentziass
approved these changes
Feb 9, 2026
dawidmalina
pushed a commit
to dawidmalina/github-runner
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/availability/issues/4918
https://github.com/github/hosted-compute/issues/3923