Fix composite post-step marker display names#4267
Merged
ericsciple merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes display name issues in composite action step markers introduced by PR #4243. The runner now correctly evaluates and displays step names for post-steps in composite actions, and avoids sending unnecessary timeline record updates for embedded steps.
Changes:
- Call
EvaluateDisplayNamedirectly instead ofTryUpdateDisplayNamefor embedded composite steps to enable display name evaluation during Post stage - Add test coverage for Post stage display name evaluation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Runner.Worker/Handlers/CompositeActionHandler.cs | Replace TryUpdateDisplayName call with EvaluateDisplayName wrapped in try-catch for embedded step display name resolution |
| src/Test/L0/Worker/Handlers/CompositeActionHandlerL0.cs | Add test verifying Post stage steps evaluate display names correctly (e.g., "Run actions/cache@v4" instead of "run") |
salmanmkc
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #4243 introduced
##[start-action]/##[end-action]markers for composite action steps. Two issues remain with the display name used in these markers:Post-step markers show
"run"instead of the resolved name.TryUpdateDisplayNameskips evaluation during the Post stage, so embedded composite post steps fall back to"run".TryUpdateDisplayNamesends unnecessary server updates for embedded steps. Embedded steps share the parent's timeline record, so updating the display name overwrites the parent step's name in the UI.Fix
Call
EvaluateDisplayNamedirectly instead ofTryUpdateDisplayNamein the composite marker emission path. This resolves the name in-memory without sending a timeline record update. Gated behind existing feature flagactions_runner_emit_composite_markers.