JDK contents extracted with wrong modification timestamps

[sdedic]

Description:
setup-java action for Zulu JDK garbles timestamps of the installed files. This may cause issues in up-to-date and dependency checking, if an application depends directly or indirectly on JDK library classes, e.g. tool APIs. It is often assumed that dependencies (in this case jars or jmods from the JDK) must be older than compiled code linked to those dependencies in order to consider that compiled code up-to-date.

Task version:
v3

Platform:

• Ubuntu 20.4.5

Runner type:

• Hosted

Repro steps:
Investigated here: apache/netbeans#4921 ; according to the logs, the extracted JDK contents bears the time-of-installation timesamp:

2022-11-15T11:50:59.9471865Z -rw-r--r--+ 1 runner docker 18348414 Nov 15 11:50 tools.jar

This is the action invocation, with the ls logged immediately after.

Expected behavior:
Installed JDK files should retain timestamps as they are stored in the installation archive.

Actual behavior:
Installed JDK files get all modification stamp from the time JDK was installed on the builder machine.

[panticmilos]

hi @sdedic, thank you for your report. We will take a look at it

[dsame]

Hello @sdedic ,

The problem is common for all repositories using actions/tool-cache package and should be addressed to the the repo support: https://github.com/actions/toolkit

the prof action/setup-go also set time stamps to the current time: https://github.com/akv-demo/test-setup-go/actions/runs/6904839604/job/18786338568#step:5:18

The function that need to be fixed:
https://github.com/actions/toolkit/blob/main/packages/tool-cache/src/tool-cache.ts#L223

Will you create the issue in https://github.com/actions/toolkit repo or prefer we do it?

[dsame]

Hello @sdedic i created the issue in the correct repo actions/toolkit#1586 and am closing the issue as a duplicate.