-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic
Description
Description:
In below documents pnpm install --frozen-lockfile, but pnpm passes the --frozen-lockfile option automatically when it detects that it is running on CI (i.e. on GitHub Actions).
setup-node/docs/advanced-usage.md
Lines 246 to 266 in a4fcaaf
| **Caching pnpm (v6.10+) dependencies:** | |
| ```yaml | |
| # This workflow uses actions that are not certified by GitHub. | |
| # They are provided by a third-party and are governed by | |
| # separate terms of service, privacy policy, and support | |
| # documentation. | |
| # NOTE: pnpm caching support requires pnpm version >= 6.10.0 | |
| steps: | |
| - uses: actions/checkout@v3 | |
| - uses: pnpm/action-setup@v2 | |
| with: | |
| version: 6.32.9 | |
| - uses: actions/setup-node@v3 | |
| with: | |
| node-version: '14' | |
| cache: 'pnpm' | |
| - run: pnpm install --frozen-lockfile | |
| - run: pnpm test | |
| ``` |
I thought it seems that it is better not to pass it explicitly in document, so as not to cause unnecessary confusion.
References
- https://pnpm.io/cli/install#--frozen-lockfile
- https://github.com/watson/ci-info#supported-ci-tools
Are you willing to submit a PR?
Yes
Metadata
Metadata
Assignees
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic