Skip to content

Log node and npm versions #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmgross merged 8 commits into from
Apr 21, 2020
Merged

Log node and npm versions #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52eb8a7
Log node and npm version
joshmgross Apr 16, 2020
0dc69b3
Remove extra version logging
joshmgross Apr 16, 2020
e99a7e6
Add dist changes
joshmgross Apr 16, 2020
ffde538
Only include npm version if npm exists
joshmgross Apr 21, 2020
1e163de
Quote exec parameters
joshmgross Apr 21, 2020
2d53d29
Use actions/exec for getting version
joshmgross Apr 21, 2020
28505ad
Move version to args
joshmgross Apr 21, 2020
46903d1
Await exec calls to ensure proper version ordering
joshmgross Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15201,6 +15201,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
};
Object.defineProperty(exports, "__esModule", { value: true });
const core = __importStar(__webpack_require__(470));
const exec = __importStar(__webpack_require__(986));
const installer = __importStar(__webpack_require__(749));
const auth = __importStar(__webpack_require__(202));
const path = __importStar(__webpack_require__(622));
Expand All @@ -15218,6 +15219,12 @@ function run() {
if (version) {
yield installer.getNode(version);
}
// Output version of node and npm that are being used
yield exec.exec('node', ['--version']);
// Older versions of Node don't include npm, so don't let this call fail
yield exec.exec('npm', ['--version'], {
ignoreReturnCode: true
});
const registryUrl = core.getInput('registry-url');
const alwaysAuth = core.getInput('always-auth');
if (registryUrl) {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"license": "MIT",
"dependencies": {
"@actions/core": "^1.2.2",
"@actions/exec": "^1.0.3",
"@actions/github": "^1.1.0",
"@actions/http-client": "^1.0.6",
"@actions/io": "^1.0.2",
Expand Down
10 changes: 10 additions & 0 deletions src/setup-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import * as core from '@actions/core';
import * as exec from '@actions/exec';
import * as io from '@actions/io';
Copy link

@XhmikosR XhmikosR Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this unused @joshmgross?

import * as installer from './installer';
import * as auth from './authutil';
import * as path from 'path';
Expand All @@ -17,6 +19,14 @@ async function run() {
await installer.getNode(version);
}

// Output version of node and npm that are being used
await exec.exec('node', ['--version']);

// Older versions of Node don't include npm, so don't let this call fail
await exec.exec('npm', ['--version'], {
ignoreReturnCode: true
});

const registryUrl: string = core.getInput('registry-url');
const alwaysAuth: string = core.getInput('always-auth');
if (registryUrl) {
Expand Down