Feature: Exempt labels from action#11
Conversation
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
This looks awesome - thanks for the contribution! Left a few comments, but it generally looks great.
I'm not sure how best to test a change like this, and I'm open to any advice from the maintainers/owners of this project.
So far, we've mostly just been doing integration testing, so basically just run the action for the use cases surrounding the change. With that said, I want that to change and have an open issue (#12) to add units. For now, doing some integration testing is probably fine though - this seems like a pretty safe change to me.
Since the exempt label parameter is not required, we don't want to both checking for it if it was not defined.
This variable just tracks the number of operations we're using to avoid rate limiting. Since the exempt check wouldn't result in a rate-limited request, we don't need to reduce the variable.
|
Looks great, thanks for the contribution! |
|
Published! Both |
|
Lovely! Thanks for your help @damccorm |
|
Is it possible to set several exempt labels? |
|
@NARKOZ no |
The latest version shows as 1.0.0. Is 1.1.0 somehow not fully released yet? |
|
@bryanmacfarlane to take a look - the tag is definitely valid - https://github.com/actions/stale/releases, but it isn't showing up that way in the marketplace |
5 participants
Fixes #10
Hey! This is the first action that we've tried out on our repos and it seems great. I'm an engineer on our Developer Systems team at Wave and we support features like this to help developers get their work done.
We had an internal request for this feature, and then I saw that it was already listed as an issue so I decided to take a crack at it. Thanks to @vincentschen, @christopheranderson, and @damccorm for the discussion that's happened so far on #10.
I'm not sure how best to test a change like this, and I'm open to any advice from the maintainers/owners of this project. Thanks