-
Notifications
You must be signed in to change notification settings - Fork 406
feature: add dynamic messages support #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Created pr to get feedback. Based on that, I can update documentation. |
Relequestual
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyeballed and looks reasonable. Includes tests. Not expecting my review to count for much other than signalling I'd like to see this.
|
sumitanvekar:add-dynamic-messages |
|
this might be considered as a special case of the problem #877 |
|
haven't been able to give time tot this one to get it to mergeable state. I will try to spend sometime by next week. |
|
@IvanZosimov could you approve the workflow runs, please? |
|
any updates here to be released soon? @Relequestual 🙏 We need to be able to tag the PR author in the messages. |
|
Hey maintainers (@HarithaVattikuti @aparnajyothi-y @chiranjib-swain @priyagupta108 @Relequestual ), This PR was good effort from @sumitanvekar that even included automated tests to ensure high quality. ❤️ This is a frequently requested feature, as can be seen in the issues below, so it would be great to have the ability to dynamically tag the PR Please give us an update! 🙏 Issues that mention this feature: |
Changes
Added a feature to support {author} place holder which can be used in messages. It's built in backward compatible way.
Context
Feature request #877