✨ Add entry for SLSA Go builder#1600
Conversation
|
Note: this is the GA for https://github.blog/2022-04-07-slsa-3-compliance-with-github-actions/ /cc @MarkLodato @joshuagl @ianlewis @asraa @MarkLodato: we need an icon. Which shall we use? |
|
talked offline with @asraa. We've picked the generic SLSA logo from the website. Ready for reivew |
4323a44 to
6799f90
Compare
|
Don't you need a pure icon, not one with text? If so, then https://github.com/slsa-framework/slsa/blob/main/resources/assets/logo/SLSA-logo.svg would be appropriate instead. |
Updated the PR with this logo. Thanks |
b9a9af3 to
b20ca6b
Compare
|
friendly ping. Are there any blockers to merge this PR? /cc @josepalafox |
| @@ -0,0 +1,22 @@ | |||
| name: SLSA Go releaser | |||
There was a problem hiding this comment.
Please add a short summary:
- What does this starter workflow light up for customer?
- Any links for "more details", "support"
There was a problem hiding this comment.
I don't see this updated in the PR. Did you may be miss to push the change?
|
I am not an expert in svg, but the icon does not look like a svg file. Please check. It also does not get rendered in the GitHub editor. |
bishal-pdMSFT
left a comment
There was a problem hiding this comment.
Left some comments
| actions: read # To read workflow path. | ||
| # If you need more configuration options, such as ldflag examples, | ||
| # visit https://github.com/slsa-framework/slsa-github-generator#golang-projects. | ||
| uses: slsa-framework/slsa-github-generator/.github/workflows/builder_go_slsa3.yml@v1.0.0 |
There was a problem hiding this comment.
Not a comment for this PR but something to think about for future in case you plan to add more workflows for building other languages. Can they be encapsulated in a single workflow rather than a separate one for each language?
For example, look at codeql one which caters to multiple languages.
There was a problem hiding this comment.
Thanks for the tip. I was initially thinking of having different workflows for each language. Since most projects use a single "main" language, it would avoid noise. I'll think about this for future languages, thanks!
bishal-pdMSFT
left a comment
There was a problem hiding this comment.
LGTM apart from a small comment about description property.
|
I've addressed all the comments. Ready to merge on my side. Thank you so much for you comments and patience! |
Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.ymlfile with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKENso that the workflow runs successfully.For CI workflows, the workflow:
cidirectory.ci/properties/*.properties.jsonfile (for example,ci/properties/docker-publish.properties.json).pushtobranches: [ $default-branch ]andpull_requesttobranches: [ $default-branch ].releasewithtypes: [ created ].docker-publish.yml).For Code Scanning workflows, the workflow:
code-scanningdirectory.code-scanning/properties/*.properties.jsonfile (for example,code-scanning/properties/codeql.properties.json), with properties set as follows:name: Name of the Code Scanning integration.organization: Name of the organization producing the Code Scanning integration.description: Short description of the Code Scanning integration.categories: Array of languages supported by the Code Scanning integration.iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theiconsdirectory.pushtobranches: [ $default-branch, $protected-branches ]andpull_requesttobranches: [ $default-branch ]. We also recommend ascheduletrigger ofcron: $cron-weekly(for example,codeql.yml).Some general notes:
actionsorganization, or