Address bugbash issues#1279
Merged
Phantsure merged 2 commits intoreleases/cache-v3-betafrom Dec 22, 2022
Merged
Conversation
lvpx
approved these changes
Dec 22, 2022
Contributor
lvpx
left a comment
There was a problem hiding this comment.
LGTM. It would be great to add some context in description as to why you chose the --force method instead of the other suggested ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were few issues which came up during internal bugbash:
zstd: cache.tar already exists; not overwritten:.Possible solutions:
--forceto zstd command. Docs say that they overwrite the file with this.cache.tarfile after every list, create and extract operationFinal solution: Add --force to zstd command as problem is seen when
listruns which happen in debug mode thus justifying extra time taken in deleting and creatingcache.tarfile using --force.