Skip to content

Address bugbash issues#1279

Merged
Phantsure merged 2 commits intoreleases/cache-v3-betafrom
phantsure/bug-bash
Dec 22, 2022
Merged

Address bugbash issues#1279
Phantsure merged 2 commits intoreleases/cache-v3-betafrom
phantsure/bug-bash

Conversation

@Phantsure
Copy link
Contributor

@Phantsure Phantsure commented Dec 21, 2022

There were few issues which came up during internal bugbash:

  1. With debug logs on restore was failing saying zstd: cache.tar already exists; not overwritten:.
    Possible solutions:
  • Add --force to zstd command. Docs say that they overwrite the file with this.
  • Delete cache.tar file after every list, create and extract operation
    Final solution: Add --force to zstd command as problem is seen when list runs which happen in debug mode thus justifying extra time taken in deleting and creating cache.tar file using --force.
  1. Change debug log to info log when falling back to gzip for restoration of cache on windows.

@Phantsure Phantsure marked this pull request as ready for review December 21, 2022 12:01
@Phantsure Phantsure requested review from a team as code owners December 21, 2022 12:01
Copy link
Contributor

@lvpx lvpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be great to add some context in description as to why you chose the --force method instead of the other suggested ones.

@Phantsure Phantsure merged commit c24b93f into releases/cache-v3-beta Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants