Bypass proxy on loopback IPs (localhost, 127.*, ::1 etc) #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
changed the title
JoannaaKL
reviewed
Mar 3, 2023
| expect(res.message.statusCode).toBe(200) | ||
|
|
||
| // no support for ipv6 for now | ||
| expect(httpClient.get('http://[::1]:8091')).rejects.toThrow() |
Contributor
There was a problem hiding this comment.
Nit: I think this assertion is not relevant to this test case (we are testing the behaviour of proxy for loopback address). Maybe it could be moved into separate test?
Contributor
Author
There was a problem hiding this comment.
Currently we don't support ipv6 in httpClient.get('http://[::1]:8091'). Once we do (aka httpClient.get no longer throws), I want this test to fail, because it means proxy bypass for ipv6 loopback adresses can now be tested and verified.
JoannaaKL
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests to localhost should not be proxied (if the proxy is on another device / network, the proxied request targeting 'localhost' will likely be lost)
The runner also ignores loopback IPs
Golang as well